Defining ALLOWED_HOSTS to '*' for DEBUG. /spend 10min #19

.gitlab-ci.yml

@@ -62,7 +62,6 @@ deploy preprod:
         - pip install --upgrade -r requirements-dev.txt
         - echo "DEBUG = True" > ${BASE_PATH}/project/settings/env.py
         - echo "SECRET_KEY = '$(pwgen 20 1)'" >> ${BASE_PATH}/project/settings/env.py
-        - echo "ALLOWED_HOSTS.append('\'*\'')" >> ${BASE_PATH}/project/settings/env.py
         - ${BASE_PATH}/manage.py migrate
         - touch ${BASE_PATH}/ready
     only:

README.md

@@ -34,6 +34,12 @@ os.environ["DJANGO_DEBUG"]
 os.environ["DJANGO_SECRET_KEY"]
 ```
 
+You'll also need to define a DJANGO_ALLOWED_HOSTS containing
+the FQDN of the RP before being able to run in production
+
+If DEBUG is defined as True, ALLOWED_HOSTS is set to allow connections
+from any hosts.
+
 ## Database
 
 You can run migrations with :

project/settings/__init__.py

@@ -9,3 +9,4 @@ from .auth import *  # noqa
 from .api import *  # noqa
 from .static import *  # noqa
 from .i18n import *  # noqa
+from .hosts import * # noqa

project/settings/hosts.py

+"""
+We need to define ALLOWED_HOSTS in case of debug of if we're
+locally running. If we have an env variable DJANGO_ALLOWED_HOSTS
+defined, we can use it to.
+"""
+
+import os
+
+from .env import DEBUG
+
+if DEBUG:
+    ALLOWED_HOSTS = ['*']
+else:
+    ALLOWED_HOSTS = [os.environ['DJANGO_ALLOWED_HOSTS']]