Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
LQDN Adminsys
don
Commits
cd2461a7
Verified
Commit
cd2461a7
authored
Oct 14, 2019
by
Guinness
Browse files
Fix potential security issue by validating the email structure
parent
d810f602
Changes
3
Hide whitespace changes
Inline
Side-by-side
app/controller/campaign.php
View file @
cd2461a7
...
@@ -4,6 +4,7 @@ namespace Controller;
...
@@ -4,6 +4,7 @@ namespace Controller;
use
LQDN\Command\UserUpdateTotalCommand
;
use
LQDN\Command\UserUpdateTotalCommand
;
use
LQDN\Command\UserCreateCommand
;
use
LQDN\Command\UserCreateCommand
;
use
LQDN\Command\DonationCreateCommand
;
use
LQDN\Command\DonationCreateCommand
;
use
LQDN\Exception\InvalidEmailException
;
class
Campaign
extends
Controller
class
Campaign
extends
Controller
{
{
...
@@ -122,8 +123,13 @@ class Campaign extends Controller
...
@@ -122,8 +123,13 @@ class Campaign extends Controller
$cumul_id
=
$user
[
'cumul'
];
$cumul_id
=
$user
[
'cumul'
];
}
else
{
}
else
{
// The user does not exist, so let's create it
// The user does not exist, so let's create it
$result
=
$db
->
query
(
"INSERT INTO users (pseudo, email, hash)
try
{
VALUES ('"
.
$f3
->
get
(
'pseudo'
)
.
"', '
$email
', '
$hash
')"
);
$f3
->
get
(
'container'
)[
'command_handler'
]
->
handle
(
new
UserCreateCommand
(
$email
,
$hash
,
$f3
->
get
(
'pseudo'
),
0
,
0
));
}
catch
(
InvalidEmailException
$e
)
{
$f3
->
set
(
"error"
,
_
(
"Email Invalide"
));
$f3
->
error
(
"403"
);
}
$user_id
=
$db
->
lastInsertId
();
$user_id
=
$db
->
lastInsertId
();
}
}
}
}
...
...
src/LQDN/Exception/InvalidEmailException.php
0 → 100644
View file @
cd2461a7
<?php
namespace
LQDN\Exception
;
class
InvalidEmailException
extends
\
RuntimeException
{
}
src/LQDN/Handler/UserHandler.php
View file @
cd2461a7
...
@@ -8,6 +8,14 @@ use LQDN\Command\UserUpdateTotalCommand;
...
@@ -8,6 +8,14 @@ use LQDN\Command\UserUpdateTotalCommand;
use
LQDN\Command\UserUpdateCumulCommand
;
use
LQDN\Command\UserUpdateCumulCommand
;
use
LQDN\Command\UserCreateCommand
;
use
LQDN\Command\UserCreateCommand
;
use
LQDN\Command\AdminUpdateTotalUsersCommand
;
use
LQDN\Command\AdminUpdateTotalUsersCommand
;
use
LQDN\Exception\InvalidEmailException
;
function
checkEmail
(
$email
)
{
if
(
!
filter_var
(
$email
,
FILTER_VALIDATE_EMAIL
))
{
throw
new
InvalidEmailException
();
}
}
class
UserHandler
class
UserHandler
{
{
...
@@ -25,6 +33,7 @@ class UserHandler
...
@@ -25,6 +33,7 @@ class UserHandler
*/
*/
public
function
handleUserUpdateByAdminCommand
(
UserUpdateByAdminCommand
$command
)
public
function
handleUserUpdateByAdminCommand
(
UserUpdateByAdminCommand
$command
)
{
{
checkEmail
(
$command
->
getEmail
());
$this
->
connection
->
executeUpdate
(
'UPDATE users SET pseudo = :username, email = :email, commentaire = :comment, cumul = :cumul, total = :total WHERE id = :id'
,
[
$this
->
connection
->
executeUpdate
(
'UPDATE users SET pseudo = :username, email = :email, commentaire = :comment, cumul = :cumul, total = :total WHERE id = :id'
,
[
'username'
=>
$command
->
getUsername
(),
'username'
=>
$command
->
getUsername
(),
'email'
=>
$command
->
getEmail
(),
'email'
=>
$command
->
getEmail
(),
...
@@ -42,6 +51,7 @@ class UserHandler
...
@@ -42,6 +51,7 @@ class UserHandler
*/
*/
public
function
handleUserCreateCommand
(
UserCreateCommand
$command
)
public
function
handleUserCreateCommand
(
UserCreateCommand
$command
)
{
{
checkEmail
(
$command
->
getEmail
());
$this
->
connection
->
executeUpdate
(
'INSERT INTO users(email, hash, pseudo, total, cumul) VALUES (:email, :hash, :pseudo, :total, :cumul)'
,
[
$this
->
connection
->
executeUpdate
(
'INSERT INTO users(email, hash, pseudo, total, cumul) VALUES (:email, :hash, :pseudo, :total, :cumul)'
,
[
'email'
=>
$command
->
getEmail
(),
'email'
=>
$command
->
getEmail
(),
'hash'
=>
$command
->
getHash
(),
'hash'
=>
$command
->
getHash
(),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment