From 06778542aa0a108c5e74f687bf6fe25a8183b4f6 Mon Sep 17 00:00:00 2001 From: Okhin Date: Wed, 24 May 2017 13:39:53 +0200 Subject: [PATCH 1/2] Moving the csrf exemption to the mixin. #195 /spend 20m --- src/memopol/views/home.py | 6 ------ src/representatives_positions/views.py | 6 ++++++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/memopol/views/home.py b/src/memopol/views/home.py index 0dac726..50d4653 100644 --- a/src/memopol/views/home.py +++ b/src/memopol/views/home.py @@ -5,8 +5,6 @@ import random from django.db.models import Q, Count from django.views import generic -from django.utils.decorators import method_decorator -from django.views.decorators.csrf import csrf_exempt from representatives.models import Chamber, Representative from representatives_positions.views import PositionFormMixin @@ -22,10 +20,6 @@ class HomeView(PositionFormMixin, RepresentativeViewMixin, generic.TemplateView): template_name = 'home.html' - @method_decorator(csrf_exempt) - def dispatch(self, *args, **kwargs): - return super(HomeView, self).dispatch(*args, **kwargs) - def get_context_data(self, **kwargs): c = super(HomeView, self).get_context_data(**kwargs) diff --git a/src/representatives_positions/views.py b/src/representatives_positions/views.py index 1aa9aea..15a9bb6 100644 --- a/src/representatives_positions/views.py +++ b/src/representatives_positions/views.py @@ -1,4 +1,6 @@ from django.views import generic +from django.views.decorators.csrf import csrf_exempt +from django.utils.decorators import method_decorator from .forms import PositionForm @@ -15,6 +17,10 @@ class PositionFormMixin(generic.View): position_form = None position_created = False + @method_decorator(csrf_exempt) + def dispatch(self, *args, **kwargs): + return super(HomeView, self).dispatch(*args, **kwargs) + def post(self, request, *args, **kwargs): if 'position-representatives' in request.POST: self.position_form = PositionForm(request.POST, prefix='position') -- GitLab From cb075a45a215963e8eef0ec01b54c83955ccfdc5 Mon Sep 17 00:00:00 2001 From: Okhin Date: Wed, 24 May 2017 13:52:54 +0200 Subject: [PATCH 2/2] Fixing some copy pasta error. #195 /spend 10m --- src/representatives_positions/views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/representatives_positions/views.py b/src/representatives_positions/views.py index 15a9bb6..4a9f524 100644 --- a/src/representatives_positions/views.py +++ b/src/representatives_positions/views.py @@ -19,7 +19,7 @@ class PositionFormMixin(generic.View): @method_decorator(csrf_exempt) def dispatch(self, *args, **kwargs): - return super(HomeView, self).dispatch(*args, **kwargs) + return super(PositionFormMixin, self).dispatch(*args, **kwargs) def post(self, request, *args, **kwargs): if 'position-representatives' in request.POST: -- GitLab