Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • M memopol
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 32
    • Issues 32
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Political MemoryPolitical Memory
  • memopol
  • Merge requests
  • !85

Integrate views removed from d-r[-v]

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged njoyard requested to merge representative-views-41454979 into master Jun 08, 2016
  • Overview 5
  • Commits 7
  • Pipelines 0
  • Changes 40

Created by: njoyard

A quick summary of the changes made:

  • Gave names to API views because their default names conflicted with other view names
  • Added tags to make group/chamber/country URLs (1)
  • Moved views each to its own file and integrated views removed from d-r[-v]
  • Integrated URLs removed from d-r[-v]
  • Made URLs more homogenous (allow singular & plural ; all URLs default to singular) : moved /groups/ to /group/ and added 301 redirect from old to new

(1) I prefer using tags instead of using get_absolute_url. As models are defined in a dependency, they cannot "know" what the user application wants to use as the "canonical model url" (for example for groups it may be rep list filtered by this group, or a detail page for the group, or whatever). I could have made inherited models in memopol just to override get_absolute_url, but then making sure foreign keys use overriden models is not made easy AT ALL by django. It's possible, but the code is horrible.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: representative-views-41454979