Skip to content
Extraits de code Groupes Projets

Draft: Resolve "Compatibilité PHP 8.1"

Fermé Draft: Resolve "Compatibilité PHP 8.1"
139-compatibilite-php-8-1 into preprod
1 fil de conversation non résolu
Fermé nono requested to merge 139-compatibilite-php-8-1 into preprod
1 fil de conversation non résolu

Closes #139

Rapports de requête de fusion

Loading
Loading

Activité

Filtrer l'activité
  • Approbations
  • Assignés et relecteurs
  • Commentaires (des bots)
  • Commentaires (des utilisateurs)
  • Branches et validations
  • Modifications
  • Labels
  • État de verrouillage
  • Mentions
  • État de la demande de fusion
  • Suivi
ansible/configuration.test.yml
10 10 don_domaine: "don.test.lqdn.fr"
11 11
12 12 don_checksum_needed: "55ce33d7678c5a611085589f1f3ddf8b3c52d662cd01d4ba75c0ee0459970c2200a51f492d557530c71c15d8dba01eae"
13 don_git_branch: "122-suppression-des-pi-plomes"
13 don_git_branch: "139-compatibilite-php-8-1"
  • Porkepix
    Porkepix @Porkepix ·

    Why is this using work MR branches rather than stably named ones? (eg. test, staging, preprod, stable, prod and so on?)

  • nono
    nono @nono ·
    Auteur Owner

    Because the ansible role will checkout a branch while installing the dev environnement.

    In production, you will be using another configuration file. This one is used by Vagrant to execute the role in the VM.

  • Porkepix
    Porkepix @Porkepix ·

    Yes, but imho the preprod shouldn't be based on an MR branch. Because as soon as this MR is merged and closed, this branch is supposed to be removed and disappear. So the branch the Vagrant should be using is instead a stable one, such as preprod, the one you're trying to merge into.

  • nono
    nono @nono ·
    Auteur Owner

    Thing is, when we merge into a stable branch, that stable branch won't be deployed with that configuration file. It's expected that when you develop on a dev branch, you update that configuration file.

    But we could otherwise push a "empty" file ( variables exist, but they are not completed. ), and then ignore the updates to this configuration file when we push. Like that we don't have the issue with the branch being wrong or non-existing. Could it be a good solution ?

  • Porkepix
    Porkepix @Porkepix ·

    If this is supposed to be a dummy/template file, yeah then it's best to either remove the needed file and have a separate template file and ask the user/have a script to create the correct one on first clone, or to keep a correct working one with the correct name and add it in the .gitignore (it's still possible to commit changes to files presents in a .gitignore by forcing it), this way you update only changes needed for everyone.

  • nono changed this line in version 2 of the diff

    changed this line in version 2 of the diff

  • nono
    nono @nono ·
    Auteur Owner

    I've just added this file to the gitignore, and modified it for master.

  • Veuillez vous inscrire ou vous connecter pour répondre
  • nono added 1 commit

    added 1 commit

    • ab6907bf - Ignored configuration file for ansible testing, Resolve thread following @Porkepix 's notes

    Compare with previous version

  • nono
    nono @nono ·
    Auteur Owner

    Should not be needed, as a new site is coming soon.

  • nono closed

    closed

    • Veuillez vous inscrire ou vous connecter pour répondre