fix from ansible-lint

.ansible-lint

@@ -5,3 +5,4 @@ warn_list:
   - fqcn-builtins  # Use FQCN for builtin actions.
   - risky-file-permissions  # File permissions unset or incorrect.
   - git-latest
+  - no-changed-when

defaults/main.yml

 ---
 # defaults file for mariadb
 
-mariadb_packages: ['mariadb', 'python-pymysql']
-
+mariadb_packages: [mariadb, python-pymysql]
 mariadb_disable_tcp: true
 
 mariadb_add_users: []

handlers/main.yml

@@ -7,4 +7,4 @@
     state: restarted
 
 - name: Upgrade Mariadb
-  include_tasks: tasks/upgradedb.yml
+  ansible.builtin.include_tasks: tasks/upgradedb.yml

meta/main.yml

@@ -4,12 +4,11 @@ galaxy_info:
   role_name: mariadb
   namespace: air
   author: Fanch The System
-  name: mariadb
   description: Run mariadb on Archlinux
   license: Apache 2.0
-  min_ansible_version: 2.10
+  min_ansible_version: 2.13.9
   platforms:
-    - name: Archlinux
+    - name: ArchLinux
       versions:
         - all
 

molecule/default/converge.yml

@@ -2,15 +2,15 @@
 - name: Converge
   hosts: all
   tasks:
-    - name: "Include mariadb"
-      include_role:
-        name: "air.mariadb"
+    - name: Include mariadb
+      ansible.builtin.include_role:
+        name: air.mariadb
       vars:
         mariadb_add_users:
-          - name: 'alice'
-            password: 'easy_pass'
-            priv: 'alicedb.*:ALL'
+          - name: alice
+            password: easy_pass
+            priv: alicedb.*:ALL
         mariadb_add_dbs:
-          - name: 'alicedb'
-            encoding: 'utf8mb4'
-            collation: 'utf8mb4_general_ci'
+          - name: alicedb
+            encoding: utf8mb4
+            collation: utf8mb4_general_ci

tasks/conf.yml

 ---
-
 - name: Disable Network Access (use only socket)
-  lineinfile:
+  ansible.builtin.lineinfile:
     path: /etc/my.cnf.d/server.cnf
     state: present
-    insertafter: '^\[mysqld\]'
-    regexp: '^skip-networking'
-    line: 'skip-networking'
+    insertafter: ^\[mysqld\]
+    regexp: ^skip-networking
+    line: skip-networking
   notify: Restart Mariadb Service
   when: mariadb_disable_tcp
 
 - name: Define Transaction Isolation
-  lineinfile:
+  ansible.builtin.lineinfile:
     path: /etc/my.cnf.d/server.cnf
     state: present
-    insertafter: '^\[mysqld\]'
-    regexp: '^transaction_isolation'
-    line: 'transaction_isolation=READ-COMMITTED'
+    insertafter: ^\[mysqld\]
+    regexp: ^transaction_isolation
+    line: transaction_isolation=READ-COMMITTED
   notify: Restart Mariadb Service

tasks/enable.yml

 ---
-
 - name: Enable Mariadb
   ansible.builtin.service:
     name: mariadb

tasks/initdb.yml

 ---
-
 - name: Init Database Cluster
-  command: |
+  ansible.builtin.command: |
     mariadb-install-db --user=mysql --basedir=/usr --datadir=/var/lib/mysql \
     --skip-test-db \
     --auth-root-authentication-method=socket
   args:
-    creates: "/var/lib/mysql/*"
+    creates: /var/lib/mysql/*
 
 # mysql_secure_installation should not be need after 10.4
 # https://mariadb.com/kb/en/authentication-from-mariadb-104/

tasks/install.yml

 ---
-
 - name: Install Packages
   ansible.builtin.package:
     name: "{{ mariadb_packages }}"

tasks/main.yml

@@ -2,16 +2,12 @@
 # tasks file for mariadb
 
 - name: Install Mariadb
-  include_tasks: install.yml
-
+  ansible.builtin.include_tasks: install.yml
 - name: Init Database
-  include_tasks: initdb.yml
-
+  ansible.builtin.include_tasks: initdb.yml
 - name: Local Config
-  include_tasks: conf.yml
-
+  ansible.builtin.include_tasks: conf.yml
 - name: Enable Service
-  include_tasks: enable.yml
-
+  ansible.builtin.include_tasks: enable.yml
 - name: Post Install
-  include_tasks: postinstall.yml
+  ansible.builtin.include_tasks: postinstall.yml

tasks/postinstall.yml

 ---
-
 # TODO: manage if there are no unix socket
 - name: Create Databases
   community.mysql.mysql_db:

tasks/upgradedb.yml

 ---
-
 - name: Upgrade databases on major releases
-  command: |
+  ansible.builtin.command: |
     mariadb-upgrade -u root